History Tab Overhaul & Domain Record Modifications Changelog

[kkmanos]

This PR is a continuation of the raised issue #1025.

We have created a wiki page providing full documentation on the proposed feature.

This PR also addresses issue #872, by adding a zone-specific changelog.

Note that the Domain Changelog does not contain Reverse records that were created automatically with the auto_ptr setting enabled, because they do not produce a history log, as stated in issue #1041.

[lgtm-com]

This pull request introduces 25 alerts when merging e05b923 into bfaf565 - view on LGTM.com

new alerts:

• 17 for Unused local variable
• 6 for Testing equality to None
• 1 for Unused import
• 1 for Module is imported with 'import' and 'import from'

[RGanor]

Amazing job you guys did here with the history overhaul!
Because of the amount of changes you introduce I would like the hear from the community their thought of these changes to make sure it compatible with their setup and needs.

I will test feature in the coming weekend but until then I got few points regarding this.

1. Look into lgtm alerts and fix them if possible
2. I saw that you added jqurey-ui in base.html. please add this in offline mode as well (in order to work without internet access)
3. Why you changed the Line in custom.js and commented out javascript function in user_profile.html ?

Thanks for you contribution!

[vmarkop]

@RGanor Thank you for your feedback!

After following your pointers we looked into and resolved the LGTM alerts raised, whilst also adding the jquery-ui files locally, for use in offline mode.

Now, as far as the third point is concerned:

• custom.js: We added an auto reload when applying the changes for record modifications, because the record-changelog isn't up-to-date when the modification is completed otherwise.
• user_profile.html: After including jquery-ui for the calendar datepicker that is used by the history search filters, we noticed that some existing tabs in the app inherited a gray background element. We found that removing the "url anchor tags" function reverses this unwanted effect, while retaining the tabs' original functionality, which we ensured after rigorous testing.

For any further observations/clarifications, please feel free to contact us at vmarkop@gunet.gr

[vmarkop]

@RGanor A slight mishap occured and we linked you the wrong email address. Please contact us at barbarousisk@gunet.gr instead in case you need anything. We apologise if any inconvenience was caused.

[ghost]

Hi @kkmanos,

thank you guys for this great work! I've yet to try out the advanced history feature, it'll come in very handy for sure.

One question on fb01274, why has powerdnsadmin/static/assets/jquery-ui-smooth-datepicker/ been committed - shouldn't that be generated via $ flask assets build?

[kkmanos]

Hello @zoeller-freinet ,

We removed jquery-ui smoothness library for the datepicker. Bootstrap datepicker will now be used for the datepicker functionality. This change has been commited in a new PR #1059.

Thanks for the feedback.

[AzorianMatt]

@kkmanos do you happen to still have detailed memories of this work? I'm trying to figure out exactly what lead to merging in very broken HTML markup that I tracked back to this PR. It seems the original design used a very typical table but during this overhaul, the table was more or less stripped out in favor of tabs but much of the markup from the table was retained with a completely broken syntax.

[kkmanos]

After taking a quick look at the file changes, we utilized macros to separate components of the template into more compact templates which were re-used, resulting in a cleaner and modular code.
Aside from that, I am not able to recall any details from the changes which were made.

[AzorianMatt]

@kkmanos duly noted, thank you for the fast response!