Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user role to view history #890

Merged
merged 9 commits into from
Mar 27, 2021
Merged

Allow user role to view history #890

merged 9 commits into from
Mar 27, 2021

Conversation

jodygilbert
Copy link
Contributor

This PR a includes a configuration option to allow the user role to view history records relating to the domains they have access to.

@lgtm-com
Copy link

lgtm-com bot commented Feb 24, 2021

This pull request introduces 1 alert when merging 7727094 into 4c19f95 - view on LGTM.com

new alerts:

  • 1 for Unused import

@jodygilbert jodygilbert changed the title Allow users to view history Allow user role to view history Mar 1, 2021
@ngoduykhanh ngoduykhanh mentioned this pull request Mar 16, 2021
@ngoduykhanh
Copy link
Contributor

Can you merge the changes from master to your branch? Sorry I was so slow with the PRs :(

@jodygilbert
Copy link
Contributor Author

no problem, I've merged the changes into master

@ngoduykhanh
Copy link
Contributor

It seems like you forgot pushing your changes to resolve the conflicting files here

@lgtm-com
Copy link

lgtm-com bot commented Mar 18, 2021

This pull request introduces 2 alerts and fixes 1 when merging c698889 into 44c4531 - view on LGTM.com

new alerts:

  • 2 for Syntax error

fixed alerts:

  • 1 for Except block handles 'BaseException'

@lgtm-com
Copy link

lgtm-com bot commented Mar 27, 2021

This pull request introduces 1 alert and fixes 1 when merging 1fb2a13 into 44c4531 - view on LGTM.com

new alerts:

  • 1 for Syntax error

fixed alerts:

  • 1 for Except block handles 'BaseException'

@ngoduykhanh ngoduykhanh merged commit 98db953 into PowerDNS-Admin:master Mar 27, 2021
@jodygilbert jodygilbert deleted the Allow-users-to-view-history branch March 27, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants