Major refactoring of the install procedure #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieterlexis
reviewed
Nov 14, 2016
|
|
||
| dnsdist_install_repo: False | ||
|
|
||
| By default the PowerDNS Recursor is installed from the os default repositories. |
There was a problem hiding this comment.
s/PowerDNS Recursor/dnsdist/
| dnsdist_install_repo: False | ||
|
|
||
| By default the PowerDNS Recursor is installed from the os default repositories. | ||
| You can install the PowerDNS Recursor package from official PowerDNS repository |
There was a problem hiding this comment.
s/PowerDNS Recursor/dnsdist/
| - hosts: pdns-dnsdists | ||
| roles: | ||
| - { role: PowerDNS.dnsdist, | ||
| dnsdist_install_repo: "{{ dnsdist_official_dnsdist_master }}" |
There was a problem hiding this comment.
'official' sounds very...... uhm.. official.. I don't have a better suggestion though
There was a problem hiding this comment.
Switched to dnsdist_powerdns_repo_master.
| template: | ||
| src: dnsdist.conf.j2 | ||
| dest: /etc/dnsdist/dnsdist.conf | ||
| validate: 'dnsdist -C %s --check-config 2>&1' |
There was a problem hiding this comment.
with this line here, the validation in the handler can go
There was a problem hiding this comment.
Removed in 806f75a
| - repository | ||
|
|
||
| - include: install-epel.yml | ||
| when: ansible_os_family == 'RedHat' |
There was a problem hiding this comment.
maybe we should have a dnsdist_install_epel variable to support people that have private EPEL-like repos?
pieterlexis
approved these changes
Nov 14, 2016
|
Please squash your changes before merging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactoring of the tasks adding the PowerDNS official repositories.