Merge pull request #13065 from Habbie/auth-backend-errorlogging

auth: report which backend failed to instantiate
PowerDNS · Jul 31, 2023 · 360bc53 · 360bc53
2 parents 952d96f + 1c5140c
commit 360bc53
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/pdns/dnsbackend.cc b/pdns/dnsbackend.cc
@@ -188,8 +188,11 @@ vector<DNSBackend *> BackendMakerClass::all(bool metadataOnly)
 
   ret.reserve(d_instances.size());
 
+  std::string current; // to make the exception text more useful
+
   try {
     for (const auto& instance : d_instances) {
+      current = instance.first + instance.second;
       DNSBackend *made = nullptr;
 
       if (metadataOnly) {
@@ -207,15 +210,15 @@ vector<DNSBackend *> BackendMakerClass::all(bool metadataOnly)
     }
   }
   catch(const PDNSException &ae) {
-    g_log<<Logger::Error<<"Caught an exception instantiating a backend: "<<ae.reason<<endl;
+    g_log<<Logger::Error<<"Caught an exception instantiating a backend (" << current << "): "<<ae.reason<<endl;
     g_log<<Logger::Error<<"Cleaning up"<<endl;
     for (auto i : ret) {
       delete i;
     }
     throw;
   } catch(...) {
     // and cleanup
-    g_log<<Logger::Error<<"Caught an exception instantiating a backend, cleaning up"<<endl;
+    g_log<<Logger::Error<<"Caught an exception instantiating a backend (" << current <<"), cleaning up"<<endl;
     for (auto i : ret) {
       delete i;
     }