Apply suggestions from code review

Co-authored-by: Remi Gacogne <github@coredump.fr>
PowerDNS · Dec 15, 2021 · 45c59fe · 45c59fe
1 parent 2eaaa7c
commit 45c59fe
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/pdns/sha.hh b/pdns/sha.hh
@@ -58,11 +58,11 @@ namespace pdns
 class SHADigest
 {
 public:
-  SHADigest(int bits)
+  SHADigest(unsigned int bits)
   {
     mdctx = EVP_MD_CTX_new();
     if (mdctx == nullptr) {
-      throw std::runtime_error("VSHADigest: P_MD_CTX_new failed");
+      throw std::runtime_error("SHADigest: EVP_MD_CTX_new failed");
     }
     switch (bits) {
     case 256:
@@ -90,7 +90,7 @@ public:
     }
   }
 
-  void process(const std::string& msg, size_t sz)
+  void process(const std::string& msg)
   {
     if (EVP_DigestUpdate(mdctx, msg.data(), msg.size()) == 0) {
       throw std::runtime_error("SHADigest: update error");
@@ -106,7 +106,7 @@ public:
       throw std::runtime_error("SHADigest: finalize error");
     }
     if (md_len != md_value.size()) {
-      throw std::runtime_error("SHADigest: inconsisten size");
+      throw std::runtime_error("SHADigest: inconsistent size");
     }
     return md_value;
   }

diff --git a/pdns/zonemd.cc b/pdns/zonemd.cc
@@ -30,7 +30,7 @@ void pdns::zonemdVerify(const DNSName& zone, ZoneParserTNG& zpt, bool& validatio
   validationDone = false;
   validationOK = false;
 
-  // scheme,hasalgo -> duplicate,zonemdrecord
+  // scheme,hashalgo -> duplicate,zonemdrecord
   struct ZoneMDAndDuplicateFlag
   {
     std::shared_ptr<ZONEMDRecordContent> record;