Merge pull request #6368 from rgacogne/dnsdist-faster-dynblocks

dnsdist: Only update the DynBlock state holders when needed
PowerDNS · Mar 20, 2018 · aaee3e9 · aaee3e9
2 parents 90cb19f + 6ddb008
commit aaee3e9
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/pdns/dnsdist-lua.cc b/pdns/dnsdist-lua.cc
@@ -822,6 +822,9 @@ void setupLuaConfig(bool client)
 
   g_lua.writeFunction("addDynBlocks",
                       [](const std::unordered_map<ComboAddress,unsigned int, ComboAddress::addressOnlyHash, ComboAddress::addressOnlyEqual>& m, const std::string& msg, boost::optional<int> seconds, boost::optional<DNSAction::Action> action) {
+                           if (m.empty()) {
+                             return;
+                           }
                            setLuaSideEffect();
 			   auto slow = g_dynblockNMG.getCopy();
 			   struct timespec until, now;
@@ -852,6 +855,9 @@ void setupLuaConfig(bool client)
 
   g_lua.writeFunction("addDynBlockSMT",
                       [](const vector<pair<unsigned int, string> >&names, const std::string& msg, boost::optional<int> seconds, boost::optional<DNSAction::Action> action) {
+                           if (names.empty()) {
+                             return;
+                           }
                            setLuaSideEffect();
 			   auto slow = g_dynblockSMT.getCopy();
 			   struct timespec until, now;