switch notimpStats to array, thanks @rgacogne

PowerDNS · Oct 19, 2023 · c8166ef · c8166ef
1 parent 0669936
commit c8166ef
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/pdns/ixfrdist-stats.cc b/pdns/ixfrdist-stats.cc
@@ -90,8 +90,12 @@ std::string ixfrdistStats::getStats() {
     stats<<"# TYPE "<<prefix<<"notimp counter"<<std::endl;
   }
 
-  for (auto const &d : notimpStats) {
-    stats<<prefix<<"notimp{opcode=\""<<d.first<<"\"} "<<d.second<<std::endl;
+  for (std::size_t i = 0; i < notimpStats.size() ; i++) {
+    auto val = notimpStats.at(i).load();
+
+    if (val > 0) {
+      stats<<prefix<<"notimp{opcode=\""<<Opcode::to_s(i)<<"\"} "<<val<<std::endl;
+    }
   }
 
   stats<<"# HELP "<<prefix<<"unknown_domain_inqueries_total Number of queries received for domains unknown to us"<<std::endl;

diff --git a/pdns/ixfrdist-stats.hh b/pdns/ixfrdist-stats.hh
@@ -71,9 +71,9 @@ class ixfrdistStats {
       progStats.unknownDomainInQueries += 1;
     }
 
-    void incrementNotImplemented(const string& opcode)
+    void incrementNotImplemented(uint8_t opcode)
     {
-      notimpStats[opcode] ++;
+      notimpStats.at(opcode) ++;
     }
 
   private:
@@ -99,7 +99,7 @@ class ixfrdistStats {
     };
 
     std::map<DNSName, perDomainStat> domainStats;
-    std::map<string, std::atomic<uint64_t>> notimpStats;
+    std::array<std::atomic<uint64_t>, 16> notimpStats;
     programStats progStats;
 
     std::map<DNSName, perDomainStat>::iterator getRegisteredDomain(const DNSName& d) {

diff --git a/pdns/ixfrdist.cc b/pdns/ixfrdist.cc
@@ -959,7 +959,7 @@ try
     g_stats.incrementUnknownDomainInQueries(mdp.d_qname);
     makeRefusedPacket(mdp, packet);
   } else if (respt == ResponseType::RefusedOpcode) {
-    g_stats.incrementNotImplemented(Opcode::to_s(mdp.d_header.opcode));
+    g_stats.incrementNotImplemented(mdp.d_header.opcode);
     makeNotimpPacket(mdp, packet);
   }
 

diff --git a/regression-tests.ixfrdist/test_Stats.py b/regression-tests.ixfrdist/test_Stats.py
@@ -33,7 +33,8 @@ class IXFRDistStatsTest(IXFRDistTest):
                          "ixfrdist_unknown_domain_inqueries_total",
                          "ixfrdist_sys_msec", "ixfrdist_user_msec",
                          "ixfrdist_real_memory_usage",
-                         "ixfrdist_fd_usage"]
+                         "ixfrdist_fd_usage",
+                         "ixfrdist_notimp"]
     metric_domain_stats = ["ixfrdist_soa_serial", "ixfrdist_soa_checks_total",
                            "ixfrdist_soa_checks_failed_total",
                            "ixfrdist_soa_inqueries_total",