Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: do not take root NSset authority updates from random packets #10125

Closed
Habbie opened this issue Mar 1, 2021 · 1 comment · Fixed by #10178
Closed

rec: do not take root NSset authority updates from random packets #10125

Habbie opened this issue Mar 1, 2021 · 1 comment · Fixed by #10178

Comments

@Habbie
Copy link
Member

Habbie commented Mar 1, 2021

Background:

It looks like Recursor accepts the new root NSset from those bad responses. While this makes sense in terms of our whole implementation, and various words from RFC2181, I don't think it makes sense to accept 'authority updates' for the root NSset. Such updates would always fall into any of these 3 classes:

  1. it's the root NSset we saw on the last prime
  2. it's a new root NSset we will see on the next prime
  3. it's garbage

Secondary to that, i wonder if we could/should be doing any DNSSEC validation on authority updates (in general, outside the root), and on our root priming.

@rgacogne
Copy link
Member

rgacogne commented Mar 2, 2021

At a very quick glance, it looks like:

It might make sense to add a special case to the sanitization code for the root NSset indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants