auth: Notification failure message displays invalid port :0

[sndrsmnk]

• Program: Authoritative
• Issue type: Bug report

Short description

When zone notifications fail to go through, pdns logs:

pdns_server[2558130]: Notification for [redacted] to 213.136.12.50:0 failed after retries

Environment

• Operating system: Ubuntu 20.04
• Software version: 4.2.1-1build2
• Software source: Ubuntu repository

Steps to reproduce

1. Have a notification fail
2. Observe logs

Expected behaviour

Expected to not show a port number, or the correct port number like ':53'.

Actual behaviour

Acutally shows an invalid ':0' port number, which is confusing during debugging of issues.

Other information

Aparently this is also present in latest master.

[Habbie]

Aparently this is also present in latest master.

confirmed