-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rec: document changes to policy.DROP better and warn on using the now unsupported way #11288
Conversation
…the callback semantics section easier to find. Also add upgrade note.
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentdnsheader pieterTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the git@github.com:omoerbeek/pdns.git repository
If the flagged items do not appear to be textIf items relate to a ...
|
4a65ab2
to
bcea352
Compare
end | ||
|
||
loc = newCA("127.0.0.1") | ||
if dq.remoteaddr:equal(loc) then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we really want to be consistent with the then
being on a new line, which I am really not a fan of:
if dq.remoteaddr:equal(loc) then | |
if dq.remoteaddr:equal(loc) | |
then |
Co-authored-by: Remi Gacogne <github@coredump.fr>
Short description
Address documentation issues with the old
pdns.DROP
method and warn ifrcode
is set to it in Lua hooks.Also fix a few other cases of inconsistent style (and errors) in the example script.
Fixes #11287
Checklist
I have: