New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindbackend: "type" omission for zones causes troubles #1284

Closed
terrorobe opened this Issue Feb 17, 2014 · 4 comments

Comments

Projects
None yet
3 participants
@terrorobe
Contributor

terrorobe commented Feb 17, 2014

a named.conf entry missing a type field like:

zone "example.com" {
   file "example.com";
}; 

will yield:

[bindbackend] Warning! Skipping '' zone 'example.com'

Please also mention the "native" type in the bindbackend docs since it's not clear how the type map to powerdns functionality.

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Feb 17, 2014

Member

(note that leaving out 'type' is a misconfig with actual BIND)

Member

Habbie commented Feb 17, 2014

(note that leaving out 'type' is a misconfig with actual BIND)

@cmouse

This comment has been minimized.

Show comment
Hide comment
@cmouse

cmouse Feb 17, 2014

Contributor

@terrorobe there is no "native" type for BIND either. Leaving type out is misconfiguration as @Habbie pointed out. Perhaps we should fail such config file?

Contributor

cmouse commented Feb 17, 2014

@terrorobe there is no "native" type for BIND either. Leaving type out is misconfiguration as @Habbie pointed out. Perhaps we should fail such config file?

@terrorobe

This comment has been minimized.

Show comment
Hide comment
@terrorobe

terrorobe Feb 17, 2014

Contributor

@cmouse But in PowerDNS "native" will make sense and give feature parity to other backends.

Failing isn't the most attractive solution, just logging a understandable message might be helpful.

Contributor

terrorobe commented Feb 17, 2014

@cmouse But in PowerDNS "native" will make sense and give feature parity to other backends.

Failing isn't the most attractive solution, just logging a understandable message might be helpful.

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Apr 28, 2014

Member

@cmouse indicated this ticket needs guidance. Here it is: do not error out on this, do something sensible instead, do log something useful. I suspect 'native' is the most sensible default.

Member

Habbie commented Apr 28, 2014

@cmouse indicated this ticket needs guidance. Here it is: do not error out on this, do something sensible instead, do log something useful. I suspect 'native' is the most sensible default.

@Habbie Habbie added auth labels Jun 12, 2014

@Habbie Habbie added this to the auth-4.1.0 milestone Dec 15, 2015

pieterlexis added a commit to pieterlexis/pdns that referenced this issue Mar 6, 2017

BIND backend: support "native" zones
Allow the use of `type native;` for zones in BIND config files. We also
assume the type is native if no type is specified.

Closes PowerDNS#1284

pieterlexis added a commit to pieterlexis/pdns that referenced this issue Mar 6, 2017

BIND backend: support "native" zones
Allow the use of `type native;` for zones in BIND config files. We also
assume the type is native if no type is specified.

Closes PowerDNS#1284

pieterlexis added a commit to pieterlexis/pdns that referenced this issue Mar 6, 2017

BIND backend: support "native" zones
Allow the use of `type native;` for zones in BIND config files. We also
assume the type is native if no type is specified.

Closes PowerDNS#1284

pieterlexis added a commit to pieterlexis/pdns that referenced this issue Mar 6, 2017

BIND backend: support "native" zones
Allow the use of `type native;` for zones in BIND config files. We also
assume the type is native if no type is specified.

Closes PowerDNS#1284

@pieterlexis pieterlexis referenced this issue Mar 6, 2017

Merged

BIND backend: support "native" zones #5115

3 of 6 tasks complete

@Habbie Habbie closed this in #5115 Mar 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment