Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dnsdist] topBandwidth() sorted output similar to other top<something> functions #3521

Closed
gryphius opened this issue Mar 7, 2016 · 0 comments

Comments

@gryphius
Copy link
Contributor

gryphius commented Mar 7, 2016

dnsdist --version
dnsdist 0.0.809g51e6325

nitpicking feature request ;-)

top() functions generally return a nicely sorted list with percentages, for example :

> topClients()
   1  192.168.23.154                           2524 82.5%
   2  192.168.23.131                            219  7.2%
   3  192.168.23.130                            158  5.2%
   4  192.168.23.180                            100  3.3%
   5  192.168.23.175                             33  1.1%
   6  192.168.23.169                             16  0.5%
   7  192.168.23.78                               6  0.2%
   8  192.168.23.108                              5  0.2%
   9  Rest                                        0  0.0%

the output of topBandwidth() however looks different/unsorted:

> topBandwidth()
  30320  192.168.23.131
   3915  192.168.23.175
    793  192.168.23.108
   2060  192.168.23.169
    648  192.168.23.78
  18965  192.168.23.130
 360978  192.168.23.154
  11699  192.168.23.180

it would be nice if topBandwith() used the same output format as the other functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants