Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prettify #4632 #4846

Open
Habbie opened this issue Jan 3, 2017 · 2 comments
Open

prettify #4632 #4846

Habbie opened this issue Jan 3, 2017 · 2 comments
Labels
dnsdist enhancement hacktoberfest
Milestone
dnsdist-helpneeded

Comments

@Habbie
Copy link
Member

Habbie commented Jan 3, 2017

#4632 fixed a real user experience problem, but did so in a brittle way.
@Habbie Habbie added this to the dnsdist-helpneeded milestone Mar 7, 2017
@jsoref
Copy link
Contributor

jsoref commented Sep 28, 2018

Some more direction might be helpful...

@Habbie
Copy link
Member Author

Habbie commented Sep 28, 2018

The patch literally recognises the Lua error text "invalid key to 'next'", while surely a better heuristic is possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dnsdist enhancement hacktoberfest
Projects
None yet
Milestone
dnsdist-helpneeded
Development

No branches or pull requests
3 participants
@Habbie @pieterlexis @jsoref