rec: Add hashed indexes to the caches, for faster retrieval #6505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieterlexis
reviewed
Apr 25, 2018
pdns/recursor_cache.cc
Outdated
| ret+= sizeof(*j); // XXX WRONG we don't know the stored size! j->size(); | ||
| ret+=(unsigned int)i.d_qname.toString().length(); | ||
| for(const auto& record : i.d_records) | ||
| ret+= sizeof(record); // XXX WRONG we don't know the stored size! j->size(); |
There was a problem hiding this comment.
- Is this comment still relevant?
j->size()has no meaning here
There was a problem hiding this comment.
given #6447, maybe just remove the comment here
There was a problem hiding this comment.
The comment is still relevant (agreed, j doesn't make sense anymore) until #6447 is merged so I'd rather keep it. I'll remove the j->size(); part.
ahupowerdns
reviewed
Apr 25, 2018
| @@ -51,7 +51,7 @@ bool NegCache::getRootNXTrust(const DNSName& qname, const struct timeval& now, N | |||
| ni->d_qtype == qtnull) { | |||
| // We have something | |||
| if ((uint32_t)now.tv_sec < ni->d_ttd) { | |||
| ne = *ni; | |||
| *ne = &(*ni); | |||
ahupowerdns
approved these changes
Apr 25, 2018
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Most of the lookups in the query (positive) and negative caches are done on the exact name only, and doing so using a hash is much more faster than using canonical ordering.
In both cases we still need canonical ordering to be able to wipe a domain and its subtree from the cache efficiently, but regular retrieval (cachecache, get()) doesn't.
Pros:
Cons:
Checklist
I have: