Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Add option to spoofRawAction to spoof multiple answers #10063

Merged
merged 1 commit into from
Feb 9, 2021
Merged

dnsdist: Add option to spoofRawAction to spoof multiple answers #10063

merged 1 commit into from
Feb 9, 2021

Conversation

tjikkun
Copy link
Contributor

@tjikkun tjikkun commented Feb 5, 2021

Short description

This adds the option to specify multiple responses with spoofRawAction

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

rgacogne
rgacogne approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! A few nits but nothing that would prevent a merge as it is.

pdns/dnsdist-lua-actions.cc Show resolved Hide resolved
pdns/dnsdist-lua-actions.cc Show resolved Hide resolved
pdns/dnsdist-lua-actions.cc Outdated Show resolved Hide resolved
pdns/dnsdist-lua-actions.cc Outdated Show resolved Hide resolved
pdns/dnsdist.cc Outdated Show resolved Hide resolved
regression-tests.dnsdist/test_Spoofing.py Outdated Show resolved Hide resolved
@rgacogne rgacogne added this to the dnsdist-1.6.0 milestone Feb 5, 2021
jsoref
jsoref reviewed Feb 5, 2021
View reviewed changes
pdns/dnsdist-console.cc Outdated Show resolved Hide resolved
@rgacogne rgacogne merged commit 4b03d60 into PowerDNS:master Feb 9, 2021
@Habbie Habbie mentioned this pull request May 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoref jsoref jsoref left review comments

@rgacogne rgacogne rgacogne approved these changes

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tjikkun @rgacogne @jsoref