Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Fix size check during trailing data addition, regression tests #10139

Merged
merged 1 commit into from Mar 3, 2021
Merged

dnsdist: Fix size check during trailing data addition, regression tests #10139

merged 1 commit into from Mar 3, 2021

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Mar 3, 2021

Short description

The size check was missing since the PacketBuffer refactoring in 1.6, and the regression test was broken at roughly the same time because dq.size does not exist anymore.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.6.0 milestone Mar 3, 2021
@rgacogne rgacogne merged commit 018dfcc into PowerDNS:master Mar 3, 2021
@rgacogne rgacogne deleted the ddist-remove-trailing-test-overflow branch March 3, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rgacogne