New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rec: Add bindings to set arbitrary key-value metadata in logged messages #10491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest of review will follow once this is non-Draft.
507d373
to
ea1e98f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. A few nits and docs are missing. Also, it would be good if somebody more knowledgeable about ffi interfaces takes a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I wonder if we should exclude lua-recursor4.cc
from the formatting, at least partially.
I turned off the clang formating for the whole |
and also properly sort .not-formated file
efb85bb
to
7c39f37
Compare
|
||
.. function:: pdns_ffi_param_add_meta_single_string_kv(pdns_ffi_param_t* ref, const char* key, const char* val) -> void | ||
|
||
.. versionadded:: 4.5.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need a backport? If so, the earliest version it's going to be in is 4.5.5, as 4.5.4 was just released without this. Otherweise the versionadded::
should be 4.6.0
|
||
.. function:: pdns_ffi_param_add_meta_single_int64_kv(pdns_ffi_param_t *ref, const char* key, int64_t val) -> void | ||
|
||
.. versionadded:: 4.5.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Short description
This PR adds new protobuf
meta
field that can contain arbitrary key-value metadata.This still needs:
New protobuf
meta
field can also be read as the following protov3 map:Checklist
I have: