Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: allow skipping arbitrary EDNS options when computing packet hash #10791

Merged
merged 6 commits into from
Oct 7, 2021

Conversation

chbruyand
Copy link
Member

Short description

This adds a new option to newPacketCache() to skip arbitrary EDNS options when hashing packets.
I was a bit unsure to keep the cookieHashing setting but this makes the lua configuration more readable.

It also affects recursor's packet cache so must be reviewed carrefully.

Fix #10585

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nits that would not prevent the merge of this PR anyway. Great work, thanks!

pdns/dnsdist-cache.hh Outdated Show resolved Hide resolved
pdns/dnsdistdist/dnsdist-lua-bindings-packetcache.cc Outdated Show resolved Hide resolved
@rgacogne rgacogne merged commit 51320f2 into PowerDNS:master Oct 7, 2021
@chbruyand chbruyand deleted the dnsdist-skip-options branch January 19, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnsdist: feature to skip arbitrary EDNS options in hashing
2 participants