Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: add support to spoof a full self-generated response from lua #11051

Merged
merged 2 commits into from Dec 16, 2021
Merged

dnsdist: add support to spoof a full self-generated response from lua #11051

merged 2 commits into from Dec 16, 2021

Conversation

chbruyand
Copy link
Member

Short description

This adds the ability to set a completely self-generated raw answer from Lua

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne self-requested a review December 3, 2021 09:11
@rgacogne rgacogne added this to the dnsdist-1.8.0 milestone Dec 3, 2021
rgacogne
rgacogne approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I wonder if it would make sense to have a DNSAction::Action::SpoofPacket so that it can be used from non-FFI Lua?

pdns/dnsdist-lua-actions.cc Outdated Show resolved Hide resolved
regression-tests.dnsdist/test_Spoofing.py Show resolved Hide resolved
regression-tests.dnsdist/test_Spoofing.py Outdated Show resolved Hide resolved
@chbruyand
dnsdist: add DNSAction::Action::SpoofPacket so that spoofing can be d…
0d9e550 
…one within a regular LuaAction

- fix small (and bigger) nits reported by rgacogne, thanks.
- update regression tests with better boundaries on queries beeing spoofed
@rgacogne
Copy link
Member

The CI failure is unrelated.

@rgacogne rgacogne merged commit 9a7103c into PowerDNS:master Dec 16, 2021
@chbruyand chbruyand deleted the dnsdist-spoof-packet branch January 19, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgacogne rgacogne rgacogne approved these changes

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chbruyand @rgacogne