Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rec: Backport 11245 to rec 4.6.x: a CNAME answer on DS query should abort DS retrieval #11358

Merged
merged 2 commits into from Feb 28, 2022
Merged

rec: Backport 11245 to rec 4.6.x: a CNAME answer on DS query should abort DS retrieval #11358

merged 2 commits into from Feb 28, 2022

Conversation

omoerbeek
Copy link
Member

Short description

Backport of #11245

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@omoerbeek
If we get a CNAME when asking for a DS, we should give up and return …
1e60f00 
…vState::BogusUnableToGetDSs

(cherry picked from commit 271ae63)
@omoerbeek
Add a test for the case where an (Insecure) domain fails to get a DS
7e1ecb3 
record because of a CNAME loop, avoiding a SERVFAIL.

(cherry picked from commit c10acee)
@omoerbeek omoerbeek added this to the rec-4.6.x milestone Feb 25, 2022
@omoerbeek omoerbeek merged commit ad1a9b2 into PowerDNS:rel/rec-4.6.x Feb 28, 2022
@omoerbeek omoerbeek deleted the backport-11245-to-rec-4.6.x branch February 28, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Habbie Habbie Habbie approved these changes

Assignees
No one assigned
Labels
defect rec
Projects
None yet
Milestone
rec-4.6.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@omoerbeek @Habbie