Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geoipbackend: Support reading zones from directory #11597

Merged
merged 6 commits into from Sep 5, 2023

Conversation

cmouse
Copy link
Contributor

@cmouse cmouse commented May 1, 2022

Short description

Fixes #4439. Implements loading geoip zones from a directory in addition to the geoip master yaml file.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@cmouse cmouse force-pushed the geoipbackend-multi branch 9 times, most recently from 1fbf18b to 718df14 Compare May 2, 2022 16:51
@cmouse cmouse changed the title Geoipbackend multi geoipbackend: Support reading zones from directory May 3, 2022
@Habbie Habbie added this to the auth-4.7.0 milestone May 3, 2022
@Habbie Habbie modified the milestones: auth-4.7.0, auth-4.8.0 Sep 8, 2022
@Habbie Habbie self-assigned this Feb 21, 2023
@Habbie Habbie modified the milestones: auth-4.8.0, auth-4.9.0 Apr 14, 2023
Copy link
Member

@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I posted one doc suggestion.

Can you rebase this? I'm certain clang-tidy will have a few opinions.

docs/backends/geoip.rst Outdated Show resolved Hide resolved
@cmouse cmouse force-pushed the geoipbackend-multi branch 2 times, most recently from 47aec83 to 38169f5 Compare August 23, 2023 18:54
@Habbie Habbie merged commit fa80676 into PowerDNS:master Sep 5, 2023
74 checks passed
@cmouse cmouse deleted the geoipbackend-multi branch September 5, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple issues with GeoIPBackend
3 participants