Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rec: systemd-journal structured logging followup #11709

Merged
merged 4 commits into from Jun 21, 2022

Conversation

omoerbeek
Copy link
Member

@omoerbeek omoerbeek commented Jun 20, 2022

Short description

As @mnordhoff noted, the new systemd-journal backend isn't nice for human consumption. So switch back to the row of k=v pairs output by default and introduce a setting to use the systemd-journal backend. This setting also allows for other backends to be used (in the future).

Also: respect loglevel. The traditional output was filtered, but for structured logging, that was not done. While there, shortcut the traditional way as well, to avoid unnecessary churn.

Should fix #11705 and #11706

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Contributor

@fredmorcos fredmorcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff, nothing blocking though.

pdns/recursordist/rec-main.cc Outdated Show resolved Hide resolved
pdns/recursordist/rec-main.cc Outdated Show resolved Hide resolved
pdns/recursordist/rec-main.cc Outdated Show resolved Hide resolved
pdns/recursordist/rec-main.cc Outdated Show resolved Hide resolved
@omoerbeek omoerbeek merged commit 53891e4 into PowerDNS:master Jun 21, 2022
@omoerbeek omoerbeek deleted the rec-sd-journal-followup branch June 21, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rec: Task queue(?) logging "resolving" and "done"
2 participants