Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist-1.7.x: fix building with boost < 1.56 #12183

Merged
merged 2 commits into from Nov 10, 2022
Merged

dnsdist-1.7.x: fix building with boost < 1.56 #12183

merged 2 commits into from Nov 10, 2022

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Nov 10, 2022

Short description

partial backport of #12177, plus another fix

this makes dnsdist-1.7.x build on Amazon Linux 2 again.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

rgacogne and others added 2 commits November 10, 2022 09:17
@rgacogne @Habbie
dnsdist: Fix building with boost < 1.56
dc8e742 
boost::optional::value_or() has been introduced in 1.56
and we only require 1.53, so stop using it.

(cherry picked from commit 8464c60)
@Habbie
fix one more instance of value_or that we apparently no longer have o…
5bce6b6 
…n master
@Habbie Habbie mentioned this pull request Nov 10, 2022
Merged
7 tasks
@rgacogne rgacogne added this to the dnsdist-1.7.x milestone Nov 10, 2022
@Habbie Habbie merged commit 99b540d into PowerDNS:rel/dnsdist-1.7.x Nov 10, 2022
@Habbie Habbie deleted the dnsdist-1.7.x-value_or branch November 10, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgacogne rgacogne rgacogne approved these changes

Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.7.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Habbie @rgacogne