rec: Allow both A and AAAA when importing /etc/hosts

[sspans]

This seems to do something right at least - or it might be flaming garbage.

This is my pathetic attempt at adding support for multiple addresses for entries from /etc/hosts.

Short description

Fixes #11690

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled this code
• tested this code - lightly
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)
• checked that this code was merged to master

[omoerbeek]

Thanks, I hope to look into this soon

[omoerbeek]

Need to fix/extend the unit tests

[omoerbeek]

@sspans Can you test the current version? Thanks!

[sspans]

Yes - this works as far as I can tell. Tested with 4.8.0 beta2 + this diff.

Only oddity I noticed is that the any queries are not 100% reliable, but I'm fairly certain that's unrelated to this diff.

root@gw:~/bla# grep wireless\.home  /etc/powerdns/recursor.hosts
192.168.1.100               homebridge.home.sp5.nl wireless.home.sp5.nl
2001:1c02:21d:1101::100     homebridge.home.sp5.nl wireless.home.sp5.nl

root@gw:~/bla# dig @::1 -p 5300 ANY homebridge.home.sp5.nl +noall +answer
homebridge.home.sp5.nl.	86213	IN	SOA	localhost. root. 1 604800 86400 2419200 604800
homebridge.home.sp5.nl.	86213	IN	AAAA	2001:1c02:21d:1101::100
homebridge.home.sp5.nl.	86213	IN	NS	localhost.
homebridge.home.sp5.nl.	86213	IN	A	192.168.1.100

root@gw:~/bla# dig @::1 -p 5300 ANY wireless.home.sp5.nl +noall +answer
wireless.home.sp5.nl.	86193	IN	A	192.168.1.100
wireless.home.sp5.nl.	86193	IN	AAAA	2001:1c02:21d:1101::100
wireless.home.sp5.nl.	86193	IN	SOA	localhost. root. 1 604800 86400 2419200 604800
wireless.home.sp5.nl.	86193	IN	NS	localhost.

root@gw:~/bla# dig @::1 -p 5300 -x 192.168.1.100  +noall +answer
100.1.168.192.in-addr.arpa. 86400 IN	PTR	homebridge.home.sp5.nl.
root@gw:~/bla# dig @::1 -p 5300 -x      2001:1c02:21d:1101::100  +noall +answer
0.0.1.0.0.0.0.0.0.0.0.0.0.0.0.0.1.0.1.1.d.1.2.0.2.0.c.1.1.0.0.2.ip6.arpa. 86400	IN PTR homebridge.home.sp5.nl.

[omoerbeek]

Only oddity I noticed is that the any queries are not 100% reliable, but I'm fairly certain that's unrelated to this diff.

ANY queries rely on what happens to be cached. So they depend on query history , TTLs and cache eviction policy.

As there was an update after your test, could you retest? Thanks!

[sspans]

No functional changes for me, everything still works.
Do note that I'm not a user of the search-domain bits.

[omoerbeek]

Investigating test failure, I probably committed the wrong version of the test.

[omoerbeek]

Something fishy is going on with the workflows. Last CI run is using 16d51b6 while the force push updated to 1362a82. Also results of workflow run are missing below.