Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: luarecords, enhance ifportup() with lists of sets of addresses like ifurlup() #12669

Merged
merged 4 commits into from Apr 21, 2023

Conversation

chbruyand
Copy link
Member

@chbruyand chbruyand commented Mar 21, 2023

Short description

This PR allows to provide ifportup() with both a list of addresses or a set of list of addresses thus allowing to prioritize some addresses over others like in ifurlup().

-- Examples:
ifportup(443, {'192.0.2.1', '192.0.2.2'})
ifportup(443, {{'192.0.2.1', '192.0.2.2'}, {'198.51.100.1'}})

Fix #10297

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@Habbie Habbie added this to the auth-4.8.0 milestone Mar 21, 2023
@Habbie
Copy link
Member

Habbie commented Mar 21, 2023

Thanks, looks clean! Can you add tests and docs?

@mnordhoff
Copy link
Contributor

mnordhoff commented Mar 21, 2023

This fixes #10297. I think.

@chbruyand
Copy link
Member Author

chbruyand commented Mar 22, 2023

This fixes #10297. I think.

Indeed, thanks for the hint!

@rgacogne rgacogne self-requested a review March 22, 2023 08:38
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Habbie Habbie merged commit 277508d into PowerDNS:master Apr 21, 2023
73 checks passed
@chbruyand chbruyand deleted the auth-ifurlup-ips branch January 19, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple groups of IP addresses for ifportup
4 participants