Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add an option to write grepq's output to a file #12689

Merged
merged 2 commits into from Mar 28, 2023

Conversation

rgacogne
Copy link
Member

Short description

We regularly ask for the output of grepq("") while investigating issues, and it sometimes is too big to be practical to retrieve via the console.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Member

@omoerbeek omoerbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits

pdns/dnsdist-lua-inspection.cc Show resolved Hide resolved
pdns/dnsdist-lua-inspection.cc Show resolved Hide resolved
pdns/dnsdist-lua-inspection.cc Show resolved Hide resolved
@rgacogne rgacogne requested a review from omoerbeek March 28, 2023 08:05
@rgacogne rgacogne merged commit 940477b into PowerDNS:master Mar 28, 2023
73 checks passed
@rgacogne rgacogne deleted the ddist-grepq-tofile branch March 28, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants