Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify log message for NODATA/NXDOMAIN without AA #12805

Merged
merged 1 commit into from Jul 10, 2023

Conversation

hlindqvist
Copy link
Contributor

Short description

This adds contextual information to the log message when there is a SOA record in the authority section (typical for NODATA/NXDOMAIN) but the AA flag is not set.

The old log message did not indicate the specific reason why the record was considered irrelevant, logging only information about a SOA record that quite likely is both normal and relevant.

This somewhat helps explaining what the actual problem is.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

The old log message did not indicate the specific reason why the
record was considered irrelevant, logging only information about
a SOA record that quite likely is both normal and relevant.

This somewhat helps explaining what the actual problem is.
@Habbie Habbie added the rec label May 11, 2023
@rgacogne
Copy link
Member

rgacogne commented Jul 3, 2023

The clang-tidy failure in our CI is unrelated to this change.

@omoerbeek omoerbeek merged commit 85b87b1 into PowerDNS:master Jul 10, 2023
72 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants