Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: uid_t and gid_t can be unsigned, so doing > on an -1 value is tricky #12904

Merged

Conversation

omoerbeek
Copy link
Member

Short description

Follow up to the delinting of this code in #12836. Originally the type used was int.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@omoerbeek omoerbeek added the rec label Jun 12, 2023
@omoerbeek omoerbeek added this to the rec-4.9.0 milestone Jun 12, 2023
@omoerbeek omoerbeek changed the title rec: uid_t and gid_t can be unsigned, so doing > on and -1 value is tricky rec: uid_t and gid_t can be unsigned, so doing > on an -1 value is tricky Jun 12, 2023
@omoerbeek omoerbeek merged commit 27c01b7 into PowerDNS:master Jun 12, 2023
74 checks passed
@omoerbeek omoerbeek deleted the rec-gid_t-uid_t-can-be-unsigned branch June 12, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants