Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rec: include qname when logging skip of step 4 of qname minimization #12957

Merged
merged 1 commit into from Jun 28, 2023
Merged

rec: include qname when logging skip of step 4 of qname minimization #12957

merged 1 commit into from Jun 28, 2023

Conversation

dwfreed
Copy link
Contributor

@dwfreed dwfreed commented Jun 28, 2023

Short description

Fixes an issue where the trace looks whack because the log line doesn't include the qname. Also affects 4.9

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@omoerbeek omoerbeek added this to the rec-4.10.0 milestone Jun 28, 2023
@omoerbeek omoerbeek merged commit 101f850 into PowerDNS:master Jun 28, 2023
74 checks passed
@dwfreed dwfreed deleted the patch-1 branch June 28, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omoerbeek omoerbeek omoerbeek approved these changes

Assignees
No one assigned
Labels
rec
Projects
None yet
Milestone
rec-5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dwfreed @omoerbeek