Fix building our fuzzing targets from a dist tarball #13145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now all of our fuzzing targets where built with the authoritative server, even though one of them is specific to dnsdist. This made it easy to build all of them at once, especially for OSS-Fuzz and CI-Fuzz, but had the unfortunate drawback of pulling several dnsdist-specific files into the main pdns/ directory for no good reason. It also prevented building the fuzzing targets from a dist tarball/directory. This commit moves the dnsdist-specific fuzzing target to the dnsdist build process, and ensure that the standalone_fuzz_target_runner.cc file is part of the dist tarball, making it possible to build the fuzzing targets from the dist. It does not move the dnsdist-specific files to the pdns/dnsdistdist/ directory yet because this would conflict with existing PRs.
romeroalx
approved these changes
Aug 18, 2023
Merged
8 tasks
Habbie
approved these changes
Sep 5, 2023
|
I'm going to merge this pull request, which means that the dnsdist fuzzing will no longer get built either OSS-fuzz or CI-fuzz. It should not cause any error, and I'll open a pull request against the OSS-fuzz repository right away. |
This was referenced Sep 7, 2023
rgacogne
added a commit
to rgacogne/oss-fuzz
that referenced
this pull request
Sep 7, 2023
PowerDNS recently [1] refactored the way fuzzing targets were handled, and decided to split them per-product inside the monorepo. We thus now need to build the DNSDist targets separately from the Authoritative Server's ones. [1]: PowerDNS/pdns#13145
jonathanmetzman
pushed a commit
to google/oss-fuzz
that referenced
this pull request
Sep 7, 2023
PowerDNS recently [1] refactored the way fuzzing targets were handled, and decided to split them per-product inside the monorepo. We thus now need to build the DNSDist targets separately from the Authoritative Server's ones. [1]: PowerDNS/pdns#13145
gedigi
pushed a commit
to gedigi/oss-fuzz
that referenced
this pull request
Sep 27, 2023
PowerDNS recently [1] refactored the way fuzzing targets were handled, and decided to split them per-product inside the monorepo. We thus now need to build the DNSDist targets separately from the Authoritative Server's ones. [1]: PowerDNS/pdns#13145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Until now all of our fuzzing targets where built with the authoritative server, even though one of them is specific to dnsdist.
This made it easy to build all of them at once, especially for OSS-Fuzz and CI-Fuzz, but had the unfortunate drawback of pulling several dnsdist-specific files into the main
pdns/directory for no good reason. It also prevented building the fuzzing targets from a dist tarball/directory.This commit moves the dnsdist-specific fuzzing target to the dnsdist build process, and ensure that the
standalone_fuzz_target_runner.ccfile is part of the dist tarball, making it possible to build the fuzzing targets from the dist.It does not move the dnsdist-specific files to the
pdns/dnsdistdist/directory yet because this would conflict with existing PRs.This will require a follow-up pull request for OSS-Fuzz and CI-Fuzz to pick up the dnsdist fuzzing target once this PR has been merged.
Checklist
I have: