Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Make QName Minimization parameters from RFC 9156 settable #13296

Merged
merged 4 commits into from Oct 11, 2023

Conversation

omoerbeek
Copy link
Member

@omoerbeek omoerbeek commented Sep 25, 2023

Also fix a counting ommission

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@omoerbeek omoerbeek added this to the rec-5.0.0 milestone Sep 25, 2023
@omoerbeek omoerbeek changed the title rec: Make QNAme Minimization parameters from RFC 9156 settable rec: Make QName Minimization parameters from RFC 9156 settable Sep 25, 2023
@rgacogne rgacogne self-requested a review October 2, 2023 08:08
pdns/recursordist/rec-main.cc Outdated Show resolved Hide resolved
pdns/recursordist/syncres.cc Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6483399738

  • 5 of 9 (55.56%) changed or added relevant lines in 3 files are covered.
  • 22 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.009%) to 56.363%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/recursordist/rec-main.cc 0 2 0.0%
pdns/recursordist/syncres.cc 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
pdns/pollmplexer.cc 1 82.61%
pdns/dnsdist.cc 2 70.79%
pdns/opensslsigners.cc 2 62.14%
pdns/query-local-address.cc 2 54.26%
pdns/tcpiohandler.cc 3 66.83%
pdns/recursordist/settings/cxxsettings-generated.cc 6 91.55%
pdns/recursordist/test-syncres_cc1.cc 6 89.12%
Totals Coverage Status
Change from base Build 6481383168: 0.009%
Covered Lines: 102358
Relevant Lines: 151156

💛 - Coveralls

@omoerbeek omoerbeek merged commit 1f26186 into PowerDNS:master Oct 11, 2023
72 of 74 checks passed
@omoerbeek omoerbeek deleted the rec-qm-iters branch October 11, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants