Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Require Quiche >= 0.15.0 #13437

Merged
merged 1 commit into from Nov 9, 2023

Conversation

rgacogne
Copy link
Member

Short description

Based on the release notes the API we use did not change after that.
Fixes #13433

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Based on the release notes the API we use did not change after that.
@rgacogne rgacogne added this to the dnsdist-1.9 milestone Oct 31, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6704954598

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 436 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.2%) to 57.44%

Files with Coverage Reduction New Missed Lines %
pdns/sstuff.hh 1 61.99%
pdns/backends/gsql/gsqlbackend.hh 2 95.43%
pdns/dnsdist.cc 2 70.8%
pdns/misc.hh 3 82.52%
pdns/recursordist/syncres.hh 3 63.05%
pdns/stubresolver.cc 3 81.63%
pdns/validate.cc 4 60.61%
pdns/misc.cc 10 62.51%
pdns/mtasker.cc 11 71.2%
pdns/recursordist/test-syncres_cc1.cc 12 88.91%
Totals Coverage Status
Change from base Build 6704520672: -0.2%
Covered Lines: 105422
Relevant Lines: 152943

💛 - Coveralls

@rgacogne rgacogne merged commit d46f072 into PowerDNS:master Nov 9, 2023
74 checks passed
@rgacogne rgacogne deleted the ddist-require-quiche-0.15.0 branch November 9, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnsdist: Missing version check for Quiche
3 participants