Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rec: change default of nsec3-max-iterations to 50 #13478

Merged
merged 2 commits into from Nov 10, 2023
Merged

rec: change default of nsec3-max-iterations to 50 #13478

merged 2 commits into from Nov 10, 2023

Conversation

omoerbeek
Copy link
Member

Short description

Following the general consensus between open source vendors.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@omoerbeek omoerbeek added this to the rec-5.0.0 milestone Nov 10, 2023
@coveralls
Copy link

coveralls commented Nov 10, 2023 •
edited

Pull Request Test Coverage Report for Build 6825764397

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 195 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-0.08%) to 57.361%
Files with Coverage Reduction New Missed Lines %
pdns/opensslsigners.cc 1 62.42%
pdns/packethandler.cc 1 72.44%
pdns/misc.cc 4 62.45%
pdns/recursordist/rec-tcpout.cc 4 0.0%
pdns/signingpipe.cc 5 83.33%
pdns/tcounters.hh 5 75.0%
pdns/mtasker.cc 6 67.02%
pdns/recursordist/rec-taskqueue.cc 6 28.72%
pdns/recursordist/recursor_cache.hh 6 77.23%
pdns/recursordist/taskqueue.hh 6 42.86%
Totals Coverage Status
Change from base Build 6825027501: -0.08%
Covered Lines: 105322
Relevant Lines: 153035
💛 - Coveralls

@omoerbeek
Copy link
Member Author

Regression tests fail, will look into that.

@omoerbeek omoerbeek merged commit fe0b7a8 into PowerDNS:master Nov 10, 2023
74 checks passed
@omoerbeek omoerbeek deleted the rec-nsec3-iter-50 branch November 10, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgacogne rgacogne rgacogne approved these changes

Assignees
No one assigned
Labels
enhancement rec
Projects
None yet
Milestone
rec-5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@omoerbeek @coveralls @rgacogne