Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: disallow (by answering Refused) RD=0 by default #13507

Merged
merged 4 commits into from Dec 4, 2023

Conversation

omoerbeek
Copy link
Member

@omoerbeek omoerbeek commented Nov 17, 2023

Fixes #13386 using the option 2: send Refused before actual resolving is done. Subsequent queries for the same name with RD=0 wil be answered by the packet cache.

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@coveralls
Copy link

coveralls commented Nov 17, 2023

Pull Request Test Coverage Report for Build 7083879960

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 1 of 9 (11.11%) changed or added relevant lines in 2 files are covered.
  • 3858 unchanged lines in 77 files lost coverage.
  • Overall coverage increased (+0.2%) to 57.64%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/recursordist/pdns_recursor.cc 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
pdns/backends/gsql/gsqlbackend.hh 1 97.71%
pdns/recursordist/pdns_recursor.cc 1 1.35%
pdns/test-bindparser_cc.cc 1 94.44%
pdns/tsigverifier.cc 1 77.22%
pdns/dbdnsseckeeper.cc 2 85.88%
pdns/dnsdistdist/test-dnsdistluanetwork.cc 2 98.64%
pdns/recursordist/test-negcache_cc.cc 2 98.77%
pdns/recursordist/testrunner.cc 2 89.09%
pdns/test-communicator_hh.cc 2 95.51%
pdns/test-dnsparser_cc.cc 2 99.11%
Totals Coverage Status
Change from base Build 6890076727: 0.2%
Covered Lines: 106651
Relevant Lines: 153851

💛 - Coveralls

@omoerbeek omoerbeek force-pushed the rec-allow-rd0 branch 4 times, most recently from 9f5de55 to 75698b5 Compare November 17, 2023 13:01
Co-authored-by: phonedph1 <20867105+phonedph1@users.noreply.github.com>
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me, and the new feature makes sense as well. A regression test checking that RD=0 queries are actually refused might be nice?

@omoerbeek
Copy link
Member Author

Yes, will add test before merge.

@omoerbeek omoerbeek added this to the rec-5.0.0 milestone Dec 4, 2023
@omoerbeek omoerbeek merged commit 3a9cd2f into PowerDNS:master Dec 4, 2023
74 checks passed
@omoerbeek omoerbeek deleted the rec-allow-rd0 branch December 4, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rec: ponder introducing an ACL for RD=0 queries
4 participants