New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rec: disallow (by answering Refused) RD=0 by default #13507
Conversation
Pull Request Test Coverage Report for Build 7083879960Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
9f5de55
to
75698b5
Compare
75698b5
to
8d8ee51
Compare
Co-authored-by: phonedph1 <20867105+phonedph1@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good to me, and the new feature makes sense as well. A regression test checking that RD=0 queries are actually refused might be nice?
Yes, will add test before merge. |
Fixes #13386 using the option 2: send
Refused
before actual resolving is done. Subsequent queries for the same name with RD=0 wil be answered by the packet cache.Short description
Checklist
I have: