Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rec: a single NSEC3 record covering everything is a special case #13543

Merged
merged 2 commits into from Dec 1, 2023
Merged

rec: a single NSEC3 record covering everything is a special case #13543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
257b23b
rec: a single NSEC3 record covering everything is a special case
omoerbeek Nov 29, 2023
3f6fb38
Add test
omoerbeek Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions pdns/recursordist/aggressive_nsec.cc
View file
Open in desktop
Expand Up @@ -261,6 +261,10 @@ static bool commonPrefixIsLong(const string& one, const string& two, size_t boun
bool AggressiveNSECCache::isSmallCoveringNSEC3(const DNSName& owner, const std::string& nextHash)
{
std::string ownerHash(fromBase32Hex(owner.getRawLabel(0)));
// Special case: empty zone, so the single NSEC3 covers everything. Prefix is long but we still want it cached.
if (ownerHash == nextHash) {
return false;
}
return commonPrefixIsLong(ownerHash, nextHash, AggressiveNSECCache::s_maxNSEC3CommonPrefix);
}

Expand Down
3 changes: 3 additions & 0 deletions pdns/recursordist/test-aggressive_nsec_cc.cc
View file
Open in desktop
Expand Up @@ -21,6 +21,9 @@ BOOST_AUTO_TEST_CASE(test_small_coverering_nsec3)
{"0ujhshp2lhmnpoo9qde4blg4gq3hgl99", "7ujhshp2lhmnpoo9qde4blg4gq3hgl9a", 2, false},
{"0ujhshp2lhmnpoo9qde4blg4gq3hgl99", "fujhshp2lhmnpoo9qde4blg4gq3hgl9a", 1, false},
{"0ujhshp2lhmnpoo9qde4blg4gq3hgl99", "8ujhshp2lhmnpoo9qde4blg4gq3hgl9a", 1, false},
{"8ujhshp2lhmnpoo9qde4blg4gq3hgl99", "8ujhshp2lhmnpoo9qde4blg4gq3hgl99", 0, false},
{"8ujhshp2lhmnpoo9qde4blg4gq3hgl99", "8ujhshp2lhmnpoo9qde4blg4gq3hgl99", 1, false},
{"8ujhshp2lhmnpoo9qde4blg4gq3hgl99", "8ujhshp2lhmnpoo9qde4blg4gq3hgl99", 157, false},
};

for (const auto& [owner, next, boundary, result] : table) {
Expand Down