Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist-1.8.x: Fix code producing json #13607

Merged
merged 1 commit into from Dec 14, 2023
Merged

dnsdist-1.8.x: Fix code producing json #13607

merged 1 commit into from Dec 14, 2023

Conversation

rgacogne
Copy link
Member

Short description

Backport of #13071 to rel/dnsdist-1.8.x

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@rgacogne rgacogne added this to the dnsdist-1.8.x milestone Dec 12, 2023
@rgacogne rgacogne changed the title dnsdist-1.8x: Fix code producing json dnsdist-1.8.x: Fix code producing json Dec 12, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 12, 2023
View reviewed changes
ext/json11/json11.cpp
} else if (static_cast<uint8_t>(ch) == 0xe2 && static_cast<uint8_t>(value[i+1]) == 0x80
&& static_cast<uint8_t>(value[i+2]) == 0xa8) {
out += "\\u2028";
i += 2;

Check notice

Code scanning / CodeQL

For loop variable changed in body Note

Loop counters should not be modified in the body of the
loop
.
ext/json11/json11.cpp
} else if (static_cast<uint8_t>(ch) == 0xe2 && static_cast<uint8_t>(value[i+1]) == 0x80
&& static_cast<uint8_t>(value[i+2]) == 0xa9) {
out += "\\u2029";
i += 2;

Check notice

Code scanning / CodeQL

For loop variable changed in body Note

Loop counters should not be modified in the body of the
loop
.
@rgacogne rgacogne merged commit 58617c4 into PowerDNS:rel/dnsdist-1.8.x Dec 14, 2023
10 checks passed
@rgacogne rgacogne deleted the ddist18-13071 branch December 14, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chbruyand chbruyand chbruyand approved these changes

Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.8.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rgacogne @chbruyand @omoerbeek