Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Move the console socket instead of copying it #13735

Merged
merged 1 commit into from Jan 23, 2024

Conversation

rgacogne
Copy link
Member

Short description

Reported by Coverity as CID 414105. We don't really care about the performance impact but other tools are "helpfully" reporting this kind of missed optimizations, so let's not waste our time.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Reported by Coverity as CID 414105. We don't really care about the
performance impact but other tools are "helpfully" reporting this
kind of missed optimizations, so let's not waste our time.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7622614387

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 57.665%

Totals Coverage Status
Change from base Build 7622389749: -0.004%
Covered Lines: 107790
Relevant Lines: 155537

💛 - Coveralls

@rgacogne rgacogne merged commit fa593de into PowerDNS:master Jan 23, 2024
75 checks passed
@rgacogne rgacogne deleted the ddist-coverity-20240123 branch January 23, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants