Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rec: Backport 13788 to rec 5.0.x: fix the zoneToCache regression introduced by SA 2024-01 #13791

Merged
merged 2 commits into from Feb 26, 2024
Merged

rec: Backport 13788 to rec 5.0.x: fix the zoneToCache regression introduced by SA 2024-01 #13791

merged 2 commits into from Feb 26, 2024

Conversation

omoerbeek
Copy link
Member

Short description

Backport of #13788

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@omoerbeek omoerbeek added the rec label Feb 14, 2024
@omoerbeek omoerbeek added this to the rec-5.0.x milestone Feb 14, 2024
@coveralls
Copy link

coveralls commented Feb 14, 2024 •
edited

Pull Request Test Coverage Report for Build 8051053921

Details

  • -3 of 8 (62.5%) changed or added relevant lines in 3 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 50.903%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/zonemd.cc 0 1 0.0%
pdns/recursordist/rec-zonetocache.cc 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
pdns/recursordist/test-syncres_cc1.cc 6 88.75%
Totals Coverage Status
Change from base Build 8050394107: -0.004%
Covered Lines: 43610
Relevant Lines: 72595
💛 - Coveralls

@omoerbeek
rec: fix the zoneToCache regression introduced by SA 2024-01
658739e 
Test will follow

(cherry picked from commit c7f594e)
@omoerbeek
Test ZTC with root zone
26a82e5 
1. If code changes make the validation fail we want to know.
2. If root zone changes break something we want to know as well, this might even be more important than 1.

So I think we just have to accept the occasional network issues on GH.

(cherry picked from commit 5e7b960)
@omoerbeek omoerbeek merged commit 45734c8 into PowerDNS:rel/rec-5.0.x Feb 26, 2024
42 checks passed
@omoerbeek omoerbeek deleted the backport-13788-to-rec-5.0.x branch February 26, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgacogne rgacogne rgacogne approved these changes

Assignees
No one assigned
Labels
rec
Projects
None yet
Milestone
rec-5.0.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@omoerbeek @coveralls @rgacogne