Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth 4.9: do not disable ns records at apex in consumer zones #13897

Merged
merged 1 commit into from Mar 14, 2024

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Mar 12, 2024

Short description

backport of #13841

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@coveralls
Copy link

coveralls commented Mar 12, 2024

Pull Request Test Coverage Report for Build 8280019711

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 11 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.05%) to 63.043%

Files with Coverage Reduction New Missed Lines %
pdns/packethandler.cc 1 72.56%
pdns/iputils.hh 1 68.24%
pdns/misc.cc 1 48.78%
pdns/signingpipe.cc 2 86.02%
pdns/ws-auth.cc 2 80.8%
pdns/iputils.cc 4 32.87%
Totals Coverage Status
Change from base Build 8278809341: 0.05%
Covered Lines: 41622
Relevant Lines: 59289

💛 - Coveralls

@Habbie Habbie closed this Mar 14, 2024
@Habbie Habbie reopened this Mar 14, 2024
@Habbie Habbie merged commit e988454 into PowerDNS:rel/auth-4.9.x Mar 14, 2024
64 of 71 checks passed
@Habbie Habbie deleted the backport-13841-to-auth-4.9.x branch March 14, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants