Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist-1.9.x: Backport of 13914 - Fix XSK-enabled check when reconnecting a backend #13944

Merged
merged 1 commit into from Mar 25, 2024

Conversation

rgacogne
Copy link
Member

Short description

Backport of #13914 to 1.9.x:

The check was reverted, meaning that we did not properly remove an address:port from the XSK map when reconnecting a backend, and actually tried to remove an entry from a non-existing map when XSK is compiled in but not enabled, triggering a:

Error getting the XSK destination addresses map path '/sys/fs/bpf/dnsdist/xsk-destinations-v4'

message.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

The check was reverted, meaning that we did not properly remove an address:port from the XSK map when reconnecting a backend, and actually tried to remove an entry from a non-existing map when XSK is compiled in but not enabled, triggering a:
```
Error getting the XSK destination addresses map path '/sys/fs/bpf/dnsdist/xsk-destinations-v4'
```
message.

(cherry picked from commit bb21880)
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8340748746

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 55.51%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/dnsdistdist/dnsdist-backend.cc 0 1 0.0%
Totals Coverage Status
Change from base Build 8262456785: 0.02%
Covered Lines: 47445
Relevant Lines: 64958

💛 - Coveralls

@rgacogne rgacogne merged commit 57b3e04 into PowerDNS:rel/dnsdist-1.9.x Mar 25, 2024
12 checks passed
@rgacogne rgacogne deleted the ddist19-13914 branch March 25, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants