auth LUA: make whitespace insertion on chunk combine optional

[Habbie]

Short description

draft. Needs docs. clang-tidy will likely complain about short variable names. sorted

On backport to 4.9, make sure to flip the default for this setting to 'yes'

fixes #14002

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)
• checked that this code was merged to master

[coveralls]

Pull Request Test Coverage Report for Build 8598988894

Details

• 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• 24 unchanged lines in 5 files lost coverage.
• Overall coverage decreased (-0.003%) to 59.495%

---

Files with Coverage Reduction	New Missed Lines	%
pdns/packethandler.cc	1	72.86%
pdns/iputils.cc	2	48.01%
pdns/signingpipe.cc	2	84.41%
pdns/recursordist/test-syncres_cc1.cc	5	89.82%
modules/lmdbbackend/lmdbbackend.cc	14	72.65%

Totals
Change from base Build 8598761943:	-0.003%
Covered Lines:	114086
Relevant Lines:	159293

---

💛 - Coveralls

[neilcook]

I tested this and indeed it works as expected at execution time - a long Lua script that previous failed due to the whitespace issue now runs just fine and returns a result.
However I found that when querying the API for the record, the whitespace still appeared, which I found quite confusing, particularly as I found this before I tried executing the script, so I initially assumed it wasn't working.

[Habbie]

However I found that when querying the API for the record, the whitespace still appeared, which I found quite confusing, particularly as I found this before I tried executing the script, so I initially assumed it wasn't working.

good one. Same in pdnsutil edit-zone. I wonder if we can do the join there too, but we don't want to confuse people who did manual chunking at the same time.

[Habbie]

when querying the API for the record, the whitespace still appeared

After merging this PR, I'll reopen the original issue to cover that part of the question. We'll backport only this PR (with the default set to whitespace insertion) to 4.9 and might do API and list-zone/edit-zone for 5.0.

[rgacogne]

Looks good!