New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH Actions - Meson: Build auth using meson in build-and-test-all
.
#14036
Conversation
Pull Request Test Coverage Report for Build 8892092544Details
💛 - Coveralls |
I had a short call with @romeroalx and we discussed moving more logic into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! This is fine by me to get merged for now.
Once we merge the --enable-systemd
flag for meson you can fix that TODO and merge this PR.
One thing that irks me (but we shouldn't do anything about it just yet) is the use of environment variables. I think in the long term we want to move to being very explicit about everything we pass, so using invoke parameters would be better, and we can get rid of weird stuff like echo SANITIZERS=... >> $GITHUB_ENV
.
The systemd configure flag is added here: #14055 |
ec5f507
to
f4c02dd
Compare
That was merged. So this PR can now be merged after the systemd configure flag is enabled on meson. |
This branch has conflicts that must be resolved |
f4c02dd
to
5d69c7a
Compare
5d69c7a
to
69a82b5
Compare
Short description
Initial work as part of the tasks included in #13987 for building
auth
using Meson inside thebuild-and-test-all
workflow.Output binaries from the meson build are not installed but only generated (current
ci-make-install step
).Checklist
I have: