Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions - Meson: Build auth using meson in build-and-test-all. #14036

Merged
merged 3 commits into from May 2, 2024

Conversation

romeroalx
Copy link
Contributor

Short description

Initial work as part of the tasks included in #13987 for building auth using Meson inside the build-and-test-all workflow.

Output binaries from the meson build are not installed but only generated (current ci-make-install step).

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@coveralls
Copy link

coveralls commented Apr 5, 2024

Pull Request Test Coverage Report for Build 8892092544

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 35 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.02%) to 59.469%

Files with Coverage Reduction New Missed Lines %
pdns/iputils.hh 1 74.85%
pdns/pollmplexer.cc 1 82.39%
pdns/rcpgenerator.cc 2 90.05%
pdns/dnsdistdist/dnsdist.cc 2 68.36%
pdns/communicator.cc 3 71.85%
pdns/misc.cc 3 61.31%
pdns/auth-secondarycommunicator.cc 3 64.59%
pdns/recursordist/test-syncres_cc1.cc 5 89.71%
pdns/dnsdistdist/dnsdist-tcp.cc 5 76.05%
pdns/tcpiohandler.cc 10 66.85%
Totals Coverage Status
Change from base Build 8830304531: 0.02%
Covered Lines: 114204
Relevant Lines: 159430

💛 - Coveralls

@fredmorcos
Copy link
Contributor

I had a short call with @romeroalx and we discussed moving more logic into tasks.py in a way that completely abstract build system internals from the user and from Github workflows.

Copy link
Contributor

@fredmorcos fredmorcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This is fine by me to get merged for now.
Once we merge the --enable-systemd flag for meson you can fix that TODO and merge this PR.

One thing that irks me (but we shouldn't do anything about it just yet) is the use of environment variables. I think in the long term we want to move to being very explicit about everything we pass, so using invoke parameters would be better, and we can get rid of weird stuff like echo SANITIZERS=... >> $GITHUB_ENV.

@fredmorcos
Copy link
Contributor

The systemd configure flag is added here: #14055

@Habbie Habbie added the auth label Apr 11, 2024
@Habbie Habbie added this to the auth-5 milestone Apr 11, 2024
@fredmorcos
Copy link
Contributor

The systemd configure flag is added here: #14055

That was merged. So this PR can now be merged after the systemd configure flag is enabled on meson.

@Habbie
Copy link
Member

Habbie commented Apr 11, 2024

This branch has conflicts that must be resolved

@Habbie Habbie merged commit bbab597 into PowerDNS:master May 2, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants