auth API: when querying with rrset_name, respect it for comments too #14045
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
While
rrset_name
(plus optionallyrrset_type
) turnslist
intolookup
for records, we don't havelookup
for comments, so we need to filter those comments out explicitly after listing them all from the database.This also shows that in case of a zone with lots of comments, the 'rrset filter' (which actually -is- efficient for records) does a lot of extra work for comments.
Needs a test.
Checklist
I have: