GH actions - build-and-test-all: parameterize workflow to run different docker runner versions #14061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romeroalx
added
github_actions
Habbie
approved these changes
Apr 11, 2024
Pull Request Test Coverage Report for Build 8657820200Details
💛 - Coveralls |
romeroalx
force-pushed
the
ci-runner-image-branch
branch
from
abb33ba
to
e85b037
Compare
|
PR updated. Modified to also read from |
romeroalx
force-pushed
the
ci-runner-image-branch
branch
from
fb1ee21
to
eb9d2cf
Compare
8 tasks
rgacogne
reviewed
May 7, 2024
| steps: | ||
| - id: get-runner-image | ||
| run: | | ||
| echo "image-id=ghcr.io/$(echo '${{ github.repository }}' | cut -d '/' -f 1 | tr '[:upper:]' '[:lower:]')/${{ inputs.runner-docker-image-name || env.DEFAULT_RUNNER_DOCKER_IMAGE }}" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
Doesn't the github.repository part break CI on forks? In my fork it yields pull ghcr.io/rgacogne/base-pdns-ci-image/debian-12-pdns-base:master which fails.
There was a problem hiding this comment.
You are right! @Habbie also spotted this last Friday. I will create a new PR that fixes this
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Parameterize workflow
build-and-test-allfor running different container images as runners.This enables solving the request introduced in #13530 for testing also using
libssl1.1.Before backporting to branches
rel/auth-4.9.xandrel/dnsdist-1.9.x, it is required to approve and merge the PR PowerDNS/base-pdns-ci-image#12 inPowerDNS/base-pdns-ci-imageChecklist
I have: