Switch to blocking IO in Unix connector #2283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Socat apparently dies when the unix socket is closed at end of program.
|
Ready for merge |
|
Hi, i think pull #2284 is a better fix for this. |
|
Copied the timeout idea from #2248 and added guard for write blocking issues. |
|
Both of you please tell me what to do, preferably in agreement :) |
|
@a6502 can you comment? |
|
Ok, how about #2294 instead? |
|
Is there something wrong with this pull request? |
|
cmouse: as it stands, yes, because I don't see any change to the original pull request. Where is the 'copied the timeout idea'? |
|
@a6502's pull is no worse than this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.