Add the URI and CAA record types #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Could use a review |
| if(lenField) | ||
| stop_at = (uint8_t)d_content.at(d_pos) + d_pos + 1; | ||
| if(stop_at == 0) | ||
| stop_at = d_recordlen; |
There was a problem hiding this comment.
Why the roundabout way with the zero?
|
One nit. Code changes look fine otherwise. Did not verify actual implementation/operation of the types. |
This option (true by default) tells the writer/parser to add/read a byte that is the length of the data following.
pieterlexis
force-pushed
the
uri-and-caa
branch
from
9ff4434
to
f75f682
Compare
Habbie
added a commit
that referenced
this pull request
Mar 15, 2016
Add the URI and CAA record types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs review.