/pdns

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add `QNameLabelsCountRule()` and `QNameWireLengthRule()` #4114

Merged
merged 1 commit into from Jul 21, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
No milestone
2 participants
@rgacogne @Habbie
@rgacogne
Member

rgacogne commented Jul 5, 2016

  • QNameLabelsCountRule(min, max) matches if the qname has less than
    min or more than max labels.
  • QNameWireLengthRule(min, max) matches if the qname's length on the
    wire is less than min or more than max bytes.
  • Also add Lua bindings for DNSName's countLabels() and wirelength()
@rgacogne
dnsdist: Add `QNameLabelsCountRule()` and `QNameWireLengthRule()` 
* QNameLabelsCountRule(min, max) matches if the qname has less than
min or more than max labels.
* QNameWireLengthRule(min, max) matches if the qname's length on the
wire is less than min or more than max bytes.
* Also add Lua bindings for DNSName's `countLabels()` and `wirelength()`
Loading status checks…
57c61ce

@rgacogne rgacogne added enhancement dnsdist labels Jul 5, 2016

pdns/dnsdist-console.cc
@@ -248,7 +248,7 @@ char* my_generator(const char* text, int state)
"PoolAction(", "printDNSCryptProviderFingerprint(",
"RegexRule(", "RemoteLogAction(", "RemoteLogResponseAction(", "rmResponseRule(",
"rmRule(", "rmServer(", "roundrobin",
"QTypeRule(",
"QNameLabelsCountRule(", "QNameWireLengthRule(", "QTypeRule(",

This comment has been minimized.

Sign in to view
Copy link
@Habbie

Habbie Jul 7, 2016

Member

wonder if this list should be one item per line for better diffs. Just a thought, not suggesting it for this PR.
@Habbie

This comment has been minimized.

Sign in to view
Member

Habbie commented Jul 7, 2016

LGTM.

@Habbie Habbie merged commit 64b9ac4 into PowerDNS:master Jul 21, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-labelscount-rule branch Jul 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment