dnsdist: Add QNameLabelsCountRule() and QNameWireLengthRule()
#4114
Conversation
* QNameLabelsCountRule(min, max) matches if the qname has less than min or more than max labels. * QNameWireLengthRule(min, max) matches if the qname's length on the wire is less than min or more than max bytes. * Also add Lua bindings for DNSName's `countLabels()` and `wirelength()`
| @@ -248,7 +248,7 @@ char* my_generator(const char* text, int state) | |||
| "PoolAction(", "printDNSCryptProviderFingerprint(", | |||
| "RegexRule(", "RemoteLogAction(", "RemoteLogResponseAction(", "rmResponseRule(", | |||
| "rmRule(", "rmServer(", "roundrobin", | |||
| "QTypeRule(", | |||
| "QNameLabelsCountRule(", "QNameWireLengthRule(", "QTypeRule(", | |||
Habbie
Jul 7, 2016
Member
wonder if this list should be one item per line for better diffs. Just a thought, not suggesting it for this PR.
wonder if this list should be one item per line for better diffs. Just a thought, not suggesting it for this PR.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
QNameLabelsCountRule(min, max)matches if the qname has less thanminor more thanmaxlabels.QNameWireLengthRule(min, max)matches if the qname's length on thewire is less than
minor more thanmaxbytes.countLabels()andwirelength()