dnsdist: Reset origFD asap to keep the outstanding count correct #4365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the health check thread waited until we had finished with the IDState to set `origFD` to -1, but: * for the UDP client thread, the only difference it makes is that `outstanding` will not be incremented if `origFD` is not -1, which is not what we want since we are going to decrement it * for the UDP responder thread, it actually increases the likelihood of decrementing `outstanding` twice, once in the responder threader and once in the health check thread. This was especially likely to be an issue because the health check thread used to call `gettime()` and to acquire a mutex before setting `origFD` to -1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the health check thread waited until we had finished
with the IDState to set
origFDto -1, but:outstandingwill not be incremented iforigFDis not -1,which is not what we want since we are going to decrement it
likelihood of decrementing
outstandingtwice, once in theresponder threader and once in the health check thread.
This was especially likely to be an issue because the health check
thread used to call
gettime()and to acquire a mutex beforesetting
origFDto -1.This might help with #4344.