Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Add DNSRule::toString(), fix dtors for rules and actions #5497

Merged
merged 2 commits into from
Jul 7, 2017
Merged

dnsdist: Add DNSRule::toString(), fix dtors for rules and actions #5497

merged 2 commits into from
Jul 7, 2017

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Jul 5, 2017

Short description

  • Add a DNSRule::toString() to make debugging from Lua or the console easier
  • Add virtual destructors to DNSRule, DNSAction and DNSResponseAction so the destructors of derived classes are run even when deleted via the base type

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone Jul 5, 2017
@rgacogne rgacogne merged commit 612bbf7 into PowerDNS:master Jul 7, 2017
@rgacogne rgacogne deleted the dnsdist-dnsrule-tostring branch July 7, 2017 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dnsdist
Projects
None yet
Milestone
dnsdist-1.2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@rgacogne