New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: drop broken support for packet-specific SOA replies from backends #5512

Merged
merged 3 commits into from Jul 12, 2017

Conversation

Projects
None yet
3 participants
@zeha
Collaborator

zeha commented Jul 11, 2017

Short description

Remove DNSPacket pointer from getSOA. This was never okay to use (at least with caching enabled).

Split from #4545 per @Habbie's wish.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@zeha zeha requested a review from Habbie Jul 11, 2017

@zeha zeha added the auth label Jul 11, 2017

@zeha

This comment has been minimized.

Show comment
Hide comment
@zeha

zeha Jul 11, 2017

Collaborator

After this force-push battle... my commit does compile now and also sets dnspacket=NULL in LUABackend::getSOA(), which is probably important?

Collaborator

zeha commented Jul 11, 2017

After this force-push battle... my commit does compile now and also sets dnspacket=NULL in LUABackend::getSOA(), which is probably important?

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Jul 11, 2017

Member

dnspacket=NULL in getSOA can go away

Member

Habbie commented Jul 11, 2017

dnspacket=NULL in getSOA can go away

@Habbie Habbie added this to the auth-4.1.0 milestone Jul 12, 2017

@mind04

This comment has been minimized.

Show comment
Hide comment
@mind04

mind04 Jul 12, 2017

Contributor

LGTM

Contributor

mind04 commented Jul 12, 2017

LGTM

@Habbie Habbie merged commit 8e7cc71 into PowerDNS:master Jul 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zeha zeha deleted the zeha:soa-no-packet branch Jul 12, 2017

mind04 added a commit to mind04/pdns that referenced this pull request Jul 18, 2017

mind04 added a commit to mind04/pdns that referenced this pull request Jul 18, 2017

mind04 added a commit to mind04/pdns that referenced this pull request Jul 18, 2017

mind04 added a commit to mind04/pdns that referenced this pull request Sep 16, 2017

mind04 added a commit to mind04/pdns that referenced this pull request Sep 17, 2017

mind04 added a commit to mind04/pdns that referenced this pull request Sep 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment