Auth: drop broken support for packet-specific SOA replies from backends #5512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Habbie
reviewed
Jul 11, 2017
modules/luabackend/minimal.cc
Outdated
| @@ -176,12 +176,12 @@ bool LUABackend::get(DNSResourceRecord &rr) { | |||
| return !rr.content.empty(); | |||
| } | |||
|
|
|||
| bool LUABackend::getSOA(const DNSName &name, SOAData &soadata, DNSPacket *p) { | |||
| bool LUABackend::getSOA(const string &name, SOAData &soadata) { | |||
Habbie
reviewed
Jul 11, 2017
modules/luabackend/minimal.cc
Outdated
| @@ -176,12 +176,12 @@ bool LUABackend::get(DNSResourceRecord &rr) { | |||
| return !rr.content.empty(); | |||
| } | |||
|
|
|||
| bool LUABackend::getSOA(const DNSName &name, SOAData &soadata, DNSPacket *p) { | |||
| bool LUABackend::getSOA(const string &name, SOAData &soadata) { | |||
| dnspacket = NULL; | |||
There was a problem hiding this comment.
LUABackend::dnspacket can be removed completely now.
zeha
force-pushed
the
soa-no-packet
branch
2 times, most recently
from
1bd9e3f
to
790ba6d
Compare
zeha
force-pushed
the
soa-no-packet
branch
2 times, most recently
from
4dbb7a0
to
8e15bfc
Compare
|
After this force-push battle... my commit does compile now and also sets |
|
|
|
LGTM |
mind04
added a commit
to mind04/pdns
that referenced
this pull request
Jul 18, 2017
mind04
added a commit
to mind04/pdns
that referenced
this pull request
Jul 18, 2017
mind04
added a commit
to mind04/pdns
that referenced
this pull request
Jul 18, 2017
mind04
added a commit
to mind04/pdns
that referenced
this pull request
Sep 16, 2017
mind04
added a commit
to mind04/pdns
that referenced
this pull request
Sep 17, 2017
mind04
added a commit
to mind04/pdns
that referenced
this pull request
Sep 17, 2017
mind04
added a commit
to mind04/pdns
that referenced
this pull request
Oct 10, 2018
rgacogne
added a commit
that referenced
this pull request
Oct 15, 2018
auth: scopeMask in the SOAData structure is unused after #5512
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Remove DNSPacket pointer from getSOA. This was never okay to use (at least with caching enabled).
Split from #4545 per @Habbie's wish.
Checklist
I have: